<html>
<head><meta charset="utf-8"><title>chalk build problem · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html">chalk build problem</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205265028"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265028" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265028">(Jul 28 2020 at 17:23)</a>:</h4>
<p>Chalk release builds (on stable) are hanging on chalk-parse for me, is anyone else having the same problem?</p>



<a name="205265213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265213">(Jul 28 2020 at 17:25)</a>:</h4>
<p>Okay not entirely hanging, but taking 3 minutes just for chalk-parse seems a bit overly long compared to normal</p>



<a name="205265257"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265257" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265257">(Jul 28 2020 at 17:25)</a>:</h4>
<p>I have noticed that, I think it's mostly the LALRPOP build script but I'm not exactly sure why</p>



<a name="205265327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265327">(Jul 28 2020 at 17:26)</a>:</h4>
<p>But yeah it's pretty painful</p>



<a name="205265921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265921">(Jul 28 2020 at 17:31)</a>:</h4>
<p>I haven't bisected it or anything, so I'm not positive this is where it started, but I recall when I was working on <a href="https://github.com/rust-lang/chalk/commit/ab2561ad734f79bb9c77ce1787c0a502c7e6b2dc">this commit</a> that the builds felt much slower than usual</p>



<a name="205265971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205265971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205265971">(Jul 28 2020 at 17:31)</a>:</h4>
<p>Though I'm not sure why those changes would make lalrpop blow up like that?</p>



<a name="205266109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205266109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205266109">(Jul 28 2020 at 17:32)</a>:</h4>
<p>Possibly monomorphization in the generated code</p>



<a name="205266556"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205266556" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205266556">(Jul 28 2020 at 17:36)</a>:</h4>
<p>... which has reached 150K LOC</p>



<a name="205266680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205266680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205266680">(Jul 28 2020 at 17:37)</a>:</h4>
<p>Yeah, it's the same for me. I tried to build it once, but stopped it after 5 minutes or so</p>



<a name="205266798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205266798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205266798">(Jul 28 2020 at 17:38)</a>:</h4>
<p>Oof</p>



<a name="205268162"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205268162" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205268162">(Jul 28 2020 at 17:50)</a>:</h4>
<p><del>Weird, generating <code>parser.rs</code> and compiling that gives a compile error </del></p>



<a name="205268426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205268426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205268426">(Jul 28 2020 at 17:52)</a>:</h4>
<p>Oh never mind, made a mistake</p>



<a name="205268878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205268878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205268878">(Jul 28 2020 at 17:56)</a>:</h4>
<p>Building the parser itself doesn't take long, but with <code>chalk-parse/lib.rs</code>it suddenly takes a long time</p>



<a name="205269090"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205269090" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205269090">(Jul 28 2020 at 17:59)</a>:</h4>
<p>Hm so it is probably the generated parser then</p>



<a name="205270453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205270453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205270453">(Jul 28 2020 at 18:10)</a>:</h4>
<p><code>cargo llvm-lines</code> output:</p>
<div class="codehilite"><pre><span></span><code>  Lines          Copies       Function name
  -----          ------       -------------
  800128 (100%)  7202 (100%)  (TOTAL)
   12045 (1.5%)   165 (2.3%)  core::option::Option&lt;T&gt;::or_else
   10967 (1.4%)   169 (2.3%)  core::option::Option&lt;T&gt;::map
    6295 (0.8%)   281 (3.9%)  core::ptr::drop_in_place
    4372 (0.5%)     1 (0.0%)  tryout::parser::__parse__Program::__reduce
</code></pre></div>


<p>rust-analyzer had <a href="https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-629321690">similar issues</a>, but this seems quite a lot of llvm output</p>



<a name="205272060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205272060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205272060">(Jul 28 2020 at 18:24)</a>:</h4>
<p>Oh wow, <code>-Zself-profile</code>+<code>measureme/summarize</code>:</p>
<div class="codehilite"><pre><span></span><code>+---------------------------------------------+-----------+-----------------+----------+------------+
| Item                                        | Self time | % of total time | Time     | Item count |
+---------------------------------------------+-----------+-----------------+----------+------------+
| LLVM_lto_optimize                           | 260.49s   | 25.777          | 260.49s  | 16         |
+---------------------------------------------+-----------+-----------------+----------+------------+
| LLVM_module_optimize_module_passes          | 246.72s   | 24.415          | 246.72s  | 16         |
+---------------------------------------------+-----------+-----------------+----------+------------+
| LLVM_passes                                 | 200.22s   | 19.814          | 200.24s  | 1          |
+---------------------------------------------+-----------+-----------------+----------+------------+
| finish_ongoing_codegen                      | 199.53s   | 19.745          | 199.53s  | 1          |
+---------------------------------------------+-----------+-----------------+----------+------------+
| LLVM_module_codegen_emit_obj                | 91.28s    | 9.033           | 91.28s   | 16         |
+---------------------------------------------+-----------+-----------------+----------+------------+
| typeck_tables_of                            | 2.30s     | 0.228           | 2.34s    | 5192       |
+---------------------------------------------+-----------+-----------------+----------+------------+
| codegen_module_optimize                     | 2.09s     | 0.206           | 249.40s  | 16         |
+---------------------------------------------+-----------+-----------------+----------+------------+
| mir_borrowck                                | 1.05s     | 0.104           | 1.80s    | 5192       |
+---------------------------------------------+-----------+-----------------+----------+------------+
</code></pre></div>



<a name="205276050"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205276050" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205276050">(Jul 28 2020 at 18:57)</a>:</h4>
<p>I have no clue what I'm looking at</p>



<a name="205276977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205276977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205276977">(Jul 28 2020 at 19:04)</a>:</h4>
<p>Yeah, maybe not actually that useful, except that some llvm optimizations are taking really long</p>



<a name="205277790"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205277790" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205277790">(Jul 28 2020 at 19:10)</a>:</h4>
<p>We have the same issue in r-a. -Zself-profile isn't too useful, unfortunately</p>



<a name="205277927"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205277927" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Laurențiu <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205277927">(Jul 28 2020 at 19:12)</a>:</h4>
<p>And that llvm-lines output doesn't seem too useful. In r-a at least it pointed somewhere</p>



<a name="205277972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205277972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205277972">(Jul 28 2020 at 19:12)</a>:</h4>
<p>Yeah, in this case it's a lot of generated code</p>



<a name="205278059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278059">(Jul 28 2020 at 19:13)</a>:</h4>
<p>So it looks like the regression appeared in <a href="https://github.com/rust-lang/chalk/commit/39767db5ad1d194d4d1027c4f2e880d7509ce264">this commit</a></p>



<a name="205278086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278086">(Jul 28 2020 at 19:13)</a>:</h4>
<p>woah, that's a fast bisect</p>



<a name="205278089"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278089" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278089">(Jul 28 2020 at 19:13)</a>:</h4>
<p>Which bumped both<code>lalrpop</code> and <code>lalrpop_util</code>, which fits</p>



<a name="205278195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278195">(Jul 28 2020 at 19:14)</a>:</h4>
<p>After that commit the compile time for chalk-parse is more than doubled on my machine</p>



<a name="205278365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nathan Whitaker <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278365">(Jul 28 2020 at 19:16)</a>:</h4>
<p><span class="user-mention silent" data-user-id="125131">detrumi</span> <a href="#narrow/stream/144729-wg-traits/topic/chalk.20build.20problem/near/205278086">said</a>:</p>
<blockquote>
<p>woah, that's a fast bisect</p>
</blockquote>
<p><code>git bisect</code> is super helpful <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="205278878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205278878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205278878">(Jul 28 2020 at 19:21)</a>:</h4>
<p>Lowering <code>opt-level</code> doesn't really help, so we should revert to the older <code>lalrpop{,-util}</code> for now, and report the problem</p>



<a name="205280387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205280387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205280387">(Jul 28 2020 at 19:34)</a>:</h4>
<p>That's probably good to revert for now</p>



<a name="205280418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205280418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205280418">(Jul 28 2020 at 19:34)</a>:</h4>
<p>Was there anything in the new versions that is useful?</p>



<a name="205280868"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205280868" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205280868">(Jul 28 2020 at 19:38)</a>:</h4>
<p>The old version still works if you remove <code>features = ["lexer"]</code>, so we're not using new features it seems</p>



<a name="205282656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205282656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205282656">(Jul 28 2020 at 19:54)</a>:</h4>
<p>Is the <code>lexer</code> feature new?</p>



<a name="205282682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205282682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205282682">(Jul 28 2020 at 19:54)</a>:</h4>
<p>If we remove it now, does it still work? Maybe that's the problem here?</p>



<a name="205282947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205282947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205282947">(Jul 28 2020 at 19:57)</a>:</h4>
<p>Yeah, it's required now</p>



<a name="205283450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205283450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205283450">(Jul 28 2020 at 20:01)</a>:</h4>
<p>Wasn't that feature added to allow disabling the lexer if you don't need it? Doesn't seem like it should make a difference for chalk</p>



<a name="205284709"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205284709" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205284709">(Jul 28 2020 at 20:13)</a>:</h4>
<p>yeah, we might not need the lexer feature</p>



<a name="205286811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205286811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205286811">(Jul 28 2020 at 20:30)</a>:</h4>
<p>Seems like it's not the lexer feature, it's a change that was introduced after</p>



<a name="205286909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205286909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205286909">(Jul 28 2020 at 20:30)</a>:</h4>
<p>Bisecting lalrpop points to <a href="https://github.com/lalrpop/lalrpop/commit/0c69e99">https://github.com/lalrpop/lalrpop/commit/0c69e99</a>, increasing chalk's release build compile time from 3:26 to 4:55 on my system</p>



<a name="205287008"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205287008" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205287008">(Jul 28 2020 at 20:31)</a>:</h4>
<blockquote>
<p>perf: Move the symbol mismatch panic into a colder path<br>
Makes it easier for llvm to inline the pop functions</p>
</blockquote>
<p>Looks like it was done to improve runtime performance, by allowing more optimizations</p>



<a name="205288958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205288958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> detrumi <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205288958">(Jul 28 2020 at 20:48)</a>:</h4>
<p>Filed <a href="https://github.com/lalrpop/lalrpop/issues/543">lalrpop#543</a></p>



<a name="205293418"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205293418" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205293418">(Jul 28 2020 at 21:33)</a>:</h4>
<p>Thanks for looking into this</p>



<a name="205293429"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205293429" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205293429">(Jul 28 2020 at 21:33)</a>:</h4>
<p>I think for now, we should revert to 0.17</p>



<a name="205293512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/chalk%20build%20problem/near/205293512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/chalk.20build.20problem.html#205293512">(Jul 28 2020 at 21:34)</a>:</h4>
<p>We only need this for <code>chalk-integration</code> and we don't really care about speed there. So, I would heavily favor reducing compile times</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>